Conversation
Contributor
Author
|
This is mainly something I find helpful in prompting me to go back and add more comprehensive tests for changes. We can formally make it optional or just rely on judgment on whether to merge PRs that aren't fully covered - I'm not too tied up on what that policy is, but having the info is helpful to me, at least. |
apiology
marked this pull request as draft
June 13, 2025 13:51
apiology
marked this pull request as ready for review
June 13, 2025 14:33
Contributor
Author
|
Superceded by #996 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up a GitHub workflow which should fail if code added / modified in a PR isn't tested in a spec.