Conversation
Useful for debug-level logging being turned on selectively at dev time
apiology
marked this pull request as draft
April 21, 2025 03:04
apiology
marked this pull request as ready for review
April 21, 2025 11:20
2 tasks
apiology
commented
Jan 5, 2026
| # @return [Logger] | ||
| def logger | ||
| @@logger | ||
| if LOG_LEVELS[log_level.to_s] == DEFAULT_LOG_LEVEL |
Contributor
Author
There was a problem hiding this comment.
Can we cache this as @logger here?
Contributor
Author
There was a problem hiding this comment.
Claude:
Yes - cached as @logger in 054171d, since logger is a module_function
mixed into each including class, @logger is scoped per instance the
same way log_level is. Added a spec confirming the same instance comes
back across calls.
apiology
marked this pull request as draft
August 24, 2026 18:59
Avoid constructing a new Logger instance on every #logger call when log_level is overridden away from the default, per review comment. Add a spec confirming the same instance is returned across calls.
…-resolve # Conflicts: # lib/solargraph/logging.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for debug-level logging being turned on selectively at dev time
The idea here is that we could have code like this:
We can selectively turn on those debugging lines at dev time by temporarily adding a
log_levelmethod:As a result, only the debug lines we care about are brought in while debugging something that interacts with
SomeRandomClass