Fix resolution in blocks in type checker - #890
Merged
Merged
Conversation
apiology
changed the title
apiology
marked this pull request as draft
April 12, 2025 10:47
apiology
commented
Apr 29, 2025
| end | ||
|
|
||
| # @deprecated Please use locate_closure_pin instead | ||
| alias locate_block_pin locate_closure_pin |
Contributor
Author
apiology
commented
Jul 2, 2025
| chain = Solargraph::Parser.chain(const, filename) | ||
| block_pin = source_map.locate_block_pin(rng.start.line, rng.start.column) | ||
| closure_pin = source_map.locate_closure_pin(rng.start.line, rng.start.column) | ||
| closure_pin.rebind(api_map) |
Contributor
Author
There was a problem hiding this comment.
Here's the real change
apiology
commented
Jul 2, 2025
| @in_block = begin | ||
| tree = cursor.source.tree_at(cursor.position.line, cursor.position.column) | ||
| Parser.is_ast_node?(tree[1]) && [:block, :ITER].include?(tree[1].type) | ||
| end |
apiology
changed the title
apiology
marked this pull request as ready for review
July 2, 2025 19:43
apiology
marked this pull request as draft
August 21, 2025 14:55
apiology
marked this pull request as ready for review
August 29, 2025 21:51
This was referenced Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug affected blocks passed to define_method() - the type checker set their closure as the class of the method despite the correct annotations.