At alpha typechecking level, warn on method calls off of nilable types - #803
Closed
apiology wants to merge 215 commits into
Closed
At alpha typechecking level, warn on method calls off of nilable types#803apiology wants to merge 215 commits into
apiology wants to merge 215 commits into
Conversation
More specifically, require that all unique types of a complex type offer the same method before it can match.
apiology
changed the title
apiology
marked this pull request as draft
March 21, 2025 13:14
Contributor
Author
|
Realistically, there's enough |
```sh
$ SOLARGRAPH_ASSERTS=on bundle exec solargraph method_pin --rbs 'RuboCop::AST::ArrayNode#values'
def values: () -> Array
$ bundle exec solargraph help method_pin
Usage:
solargraph method_pin [PATH]
Options:
[--rbs], [--no-rbs], [--skip-rbs] # Output the pin as RBS
# Default: false
[--typify], [--no-typify], [--skip-typify] # Output the calculated return type of the pin from annotations
# Default: false
[--probe], [--no-probe], [--skip-probe] # Output the calculated return type of the pin from annotations and inference
# Default: false
[--stack], [--no-stack], [--skip-stack] # Show entire stack by including definitions in superclasses
# Default: false
Describe a method pin
$
```
apiology
commented
Jan 4, 2026
| # ::Array<::Solargraph::ComplexType::UniqueType> does not match | ||
| # inferred type ::Array<::Proc> for Solargraph::ComplexType#map | ||
| def map(&block) | ||
| @items.map(&block) |
Contributor
Author
There was a problem hiding this comment.
I suspect we're not understanding the &block construct
apiology
commented
Jan 4, 2026
| if !api_map.loose_unions && pin_groups.any? { |pins| pins.empty? } | ||
| pin_groups = [] | ||
| end | ||
| pins = pin_groups.flatten.uniq(&:path) |
Contributor
Author
There was a problem hiding this comment.
This is a key bit - sharpening our existing behavior when asked to require all union types to match the behavior.
…raph into stricter_unions
apiology
commented
Jan 4, 2026
| expect(checker.problems.map(&:message)) | ||
| .to eq(['Wrong argument type for #foo: a expected String, received String, nil']) | ||
| end | ||
| end |
Contributor
Author
There was a problem hiding this comment.
This is the real win here - the ability to check for potential nil issues
This was referenced Jan 7, 2026
Contributor
Author
|
Merged into v0.59 release branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require that all unique types of a complex type offer the same method before it can match when "loose unions" mode is turned off.
Depends on:
Included to fix build:
Includes for convenience: