Conversation
Regenerates the RuboCop todo file, which had drifted out of sync
with the current RuboCop/plugin versions (auto-gen-config output
differs by 112 lines from what's currently committed). Fixes the
offenses this surfaces rather than re-excluding them:
- YARD/CollectionStyle: rewrite short-form tuple-key Hash docstrings
(Hash{Array(String, String) => ...}) to the long form YARD's current
parser accepts (Hash{Array, String, String => ...}), in
api_map/constants.rb, api_map/store.rb, and doc_map.rb.
- source_map.rb: silence one YARD/CollectionStyle false positive
inline rather than widen the todo exclusion.
- spec/source/chain_spec.rb: Style/StringLiterals (single-quoted
strings) and Style/BlockDelimiters (expect { }.not_to raise_error ->
expect do end) throughout.
No behavior changes.
apiology
force-pushed
the
rubocop_todo_style_cleanup
branch
from
October 4, 2026 22:02
30ee46d to
009e5ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude: This PR was written by Claude Code on behalf of @apiology.
Problem:
.rubocop_todo.ymlno longer matches whatrubocop --auto-gen-configgenerates — the committed file differs by 112 lines, so its exclusions describe offenses that have since moved or stopped existing. Regenerating it reactivatesYARD/CollectionStyle, whose autocorrect rewrites a nested-generic Hash key type into a different type:Accepting that autocorrect would silently change documented types across the codebase rather than reformat them.
Solution: Regenerate
.rubocop_todo.yml, fix theStyle/StringLiteralsandStyle/BlockDelimitersoffenses it surfaces inspec/source/chain_spec.rb, and disableYARD/CollectionStylerather than accept its autocorrect — the same finding and fix as #1237. No behavior changes.