Remove dead TypeMethods#qualify - #1337
Open
apiology wants to merge 1 commit into
Open
Conversation
Nothing can reach this method. TypeMethods is included only by
UniqueType, which defines its own #qualify, and a method defined
directly in a class always wins over one from an included module.
ComplexType does not include TypeMethods at all -- it reaches the
module only through a method_missing forward to @items.first, which
never fires for a name the class defines itself, and ComplexType
defines its own #qualify too.
Checked at runtime rather than by reading:
UniqueType.instance_method(:qualify).owner # => UniqueType
ComplexType.instance_method(:qualify).owner # => ComplexType
ComplexType.ancestors.include?(TypeMethods) # => false
The two live implementations also take a different signature from this
one -- (api_map, *gates) rather than (api_map, context = '') -- so a
caller written against this version would not work against either.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
apiology
marked this pull request as ready for review
September 6, 2026 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
ComplexType::TypeMethods#qualifycannot be called.TypeMethodsis included only byUniqueType, which defines its own#qualify, and a method defined directly in a class wins over one from an included module.ComplexTypedoes not includeTypeMethodsat all — it reaches the module only through amethod_missingforward to@items.first, which never fires for a name the class defines itself, and it defines its own#qualifytoo.The two live implementations also take
(api_map, *gates)rather than this one's(api_map, context = ''), so a caller written against it would not work against either.Solution: Delete it.
🤖 Generated with Claude Code