Fix solargraph-rspec plugin specs - #1291
Merged
castwide merged 1 commit intoAug 30, 2026
Merged
Conversation
Specs should be fixed from the new release: https://github.com/lekemula/solargraph-rspec/releases/tag/v0.6.0
lekemula
force-pushed
the
fix-ci-solargraph-rspec-plugin
branch
from
August 12, 2026 21:55
8a9d5d0 to
a80b64c
Compare
Owner
|
Thanks! |
apiology
added a commit
to apiology/solargraph
that referenced
this pull request
Sep 2, 2026
Brings PR 1252 (Rewrite PinCache as an instance-based engine) up to date with master, so its own CI can pass again. Two failures on the stale branch: 1. spec/yard_map/mapper_spec.rb called the old Yardoc.load!(gemspec) API. Master added this spec (castwide#1279) after this branch forked, exercising a namespace-conflict fix in yard_map/mapper.rb that this branch didn't have. This branch's own Yardoc.load! now takes a path string, not a Gem::Specification, so the merged tree hit: TypeError: no implicit conversion of Gem::Specification into String The auto-merge carried master's version of the test through with no conflict, so the break landed silently. Fixed by adapting the spec to build the yardoc into a temp path first (build_docs) and loading that path, matching the pattern yardoc_spec.rb already uses. The merge itself supplies the missing namespace-conflict fix (Mapper#namespace_with_bug_fix), so the adapted spec now passes. 2. .github/workflows/plugins.yml's run_solargraph_rspec_specs job cloned a stale branch of lekemula/solargraph-rspec. Already fixed on master by castwide#1291 ("Use the original repo"), merged 2026-08-30. No local conflict; this branch never touched the file, so the merge carries master's fix through untouched. No other file needed manual resolution. Every other changed file auto-merged without conflict markers, verified file-by-file against each side's own commits touching it. Verified after merge: full spec suite 1680 examples/0 failures/67 pending; solargraph typecheck --level strong 527 problems in 89 of 250 files, with every problem not already present on this branch's old tip confirmed pre-existing on plain master (531 problems standalone) rather than merge-introduced; rubocop 48 offenses vs 51 on this branch's old tip, the improvement coming entirely from master's own rewrite of source/chain/call.rb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specs should be fixed from the new release:
https://github.com/lekemula/solargraph-rspec/releases/tag/v0.6.0