Enable solargraph-rspec tests - #1087
Closed
lekemula wants to merge 2 commits into
Closed
Conversation
lekemula
force-pushed
the
enable-solargraph-rspec-plugin-specs
branch
9 times, most recently
from
September 21, 2025 18:15
34e3f48 to
5fe1a74
Compare
lekemula
marked this pull request as ready for review
September 21, 2025 18:18
lekemula
force-pushed
the
enable-solargraph-rspec-plugin-specs
branch
from
September 27, 2025 09:43
5fe1a74 to
9c79e5b
Compare
This was referenced Oct 1, 2025
Contributor
|
@lekemula - I suspect if the new check is re-run, it will fail now that lekemula/solargraph-rspec#27 is merged - example: https://github.com/apiology/solargraph/actions/runs/18264028765/job/51995840651. You can cherry-pick apiology@cd76c38 into this branch for a fix. |
This was referenced Oct 25, 2025
Contributor
|
You can close this - the commits have been merged in already as part of a different PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/castwide/solargraph/actions/runs/17897241460/job/50885481518?pr=1087
Thank you, @apiology, for setting this important workflow. I think it's very useful to make it work also for solargraph-rspec to prevent regressions in the future. I also appreciate the reminder about the
act, which was a lifesaver!I assume the other CI failures are not related to this PR, if otherwise, let me know!
Future Work
I think we need to revisit caching of gems/yard/rbs files across the CI workflows. See similar work on solargraph-rspec.