Factor out require_paths logic to its own class - #1062
Merged
Merged
Conversation
Contributor
Author
|
This is another chunk out of #1006 |
castwide
reviewed
Sep 6, 2025
| # | ||
| # @return [Array<String>] | ||
| def require_paths | ||
| # @todo are the semantics of '*' the same as '', meaning 'don't send back any require paths'? |
Owner
There was a problem hiding this comment.
The exceptional handling for '*' can probably be deprecated at some point. I'm having trouble thinking of use cases where it's still necessary and can't be handled in other ways that don't introduce confusion.
Owner
|
Looks good, thanks! |
apiology
added a commit
to apiology/solargraph
that referenced
this pull request
Sep 11, 2025
These were moved to workspace/require_paths.rb in castwide#1062
Merged
castwide
pushed a commit
that referenced
this pull request
Sep 30, 2025
These were moved to workspace/require_paths.rb in #1062
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.