Improve a pin combination case around selfy types - #1024
Merged
castwide merged 29 commits intoSep 30, 2025
Merged
Conversation
Also improve type coverage around pin combination
apiology
marked this pull request as draft
August 4, 2025 01:17
apiology
marked this pull request as ready for review
August 28, 2025 17:17
apiology
commented
Aug 29, 2025
| end | ||
| end | ||
|
|
||
| context 'with return types that should probably be self' do |
Contributor
Author
There was a problem hiding this comment.
This exercises the new code
This was referenced Aug 29, 2025
…pin_combination_case
To avoid merge conflicts and contributors having to deal with non-intuitive RuboCop todo changes: * Lock down development versions of RuboCop and plugins so that unrelated PRs aren't affected by newly implemented RuboCop rules. * Exclude rule entirely if more than 5 files violate it today, so that PRs are less likely to cause todo file changes unless they are specifically targeted at cleanup. * Clarify guidance on RuboCop todo file in CI error message. * Fix to hopefully ensure guidance always appears in CI error message.
…pin_combination_case
…pin_combination_case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt at fixing return types that should have been 'self' during pin combination wasn't always working, due to Pin::Base#context sometimes returning Class.