Fix transitive generic interface args in Reflection#3
Merged
azjezz merged 1 commit intoMay 12, 2026
Conversation
f801084
into
carthage-software:rfc/bound-erased-generic-types-history
14 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReflectionClass::getGenericArgumentsForParentInterface() handled direct generic interfaces, but missed bindings inherited through a non-generic intermediate class or interface.
Example:
MidreportedRoot<int>, butCreported an empty list forRoot.This keeps the inheritance checker behavior unchanged. Reflection now uses the existing binding walker for the matched ancestor and walks resolved parents/interfaces when answering a transitive interface query.
Tests run:
Result: 407/407 passed for the full generics + Reflection generics run.