Fix and extend PDO selection by record IDs (fixes #607)#629
Closed
redston-maverick wants to merge 1 commit intocanopen-python:masterfrom
Closed
Fix and extend PDO selection by record IDs (fixes #607)#629redston-maverick wants to merge 1 commit intocanopen-python:masterfrom
redston-maverick wants to merge 1 commit intocanopen-python:masterfrom
Conversation
Member
|
Is this somehow related to #627? Both PRs try to "fix" the same issue. But you're changing quite a bit of code, without any kind of explanation what it does or why you think that's better. Please elaborate on the purpose. And by the way, this apparently is not based on latest master, that's why there are conflicts. |
Member
|
Total crap, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.