Skip to content

docs(adr): 0046 a standalone worker serves agent-device by default with a private profile - #954

Merged
V3RON merged 9 commits into
mainfrom
feature/952-adr
Oct 24, 2026
Merged

V3RON merged 9 commits into
mainfrom
feature/952-adr

Conversation

@V3RON

@V3RON V3RON commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

ADR 0046 for #952: a standalone worker serves agent-device by default and hands local agents a private profile. Accepted — not yet implemented; this PR is the bottom of #952's stack and merges with its last task.

Status

Implement: n/a (ADR) Review: passed (round 2 + fix-check) Hardware: n/a Gate: waiting for the stack

Review

Spec review: 4 blocking, 4 fixed, 0 notes. Code review: skipped. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 2. Tokens: 11.6M.
Runs: 9. Cost USD: 1.9089. Agent seconds: 726.

Assessment: complete

Written by an agent.

@V3RON V3RON changed the title docs(adr): 0046 a local agent reaches agent-device without a token docs(adr): 0046 a standalone worker serves agent-device by default with a private profile Oct 23, 2026
@V3RON
V3RON marked this pull request as ready for review October 23, 2026 19:51
@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Findings (round 1, ADR-only, spec lens, commit 317cfc8)

  • R1 (blocking) ADR 0046 line 70: a default-on agent-device with no command gives no doctor finding. ADR 0023 §3 says simlock doctor reports it while the edge is on. The "Narrows" header names only 0023 §1.
  • R2 (blocking) ADR 0046 line 115: all local agents share one token. ADR 0023 §4 says agents sharing a token share a tenant and the docs say not to (the website agent-device page says the same). 0046 only "builds on" §4.
  • R3 (blocking) docs/internal/adr/README.md:86: the 0046 row does not say it narrows 0023, 0030 and 0039, and those rows still don't point to 0046 (the index rule requires it). The 0046 row also sits above 0045.

Assessment: complete. Rerun: round 2 after fixes.

Written by an agent.

@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 317cfc8
Round 2: ebba7ef
Round fix-check: 7582ef8

Runs: 9. Cost USD: 1.9089. Agent seconds: 726.
Tokens input 136, output 34738, cache read 2263060, cache write 284258.
- review 1 reviewer:  0 s $0
- review 1 reviewer: claude-sonnet-5-5 223 s $0.1347
- review 1 spec: claude-opus-5-5 160 s $0.8479
- fix 1 implementer: claude-sonnet-5-5 71 s $0.1254
- review 2 reviewer: claude-sonnet-5-5 124 s $0.1708
- review 2 reviewer spec: claude-opus-5-5 52 s $0.4007
- review 2 reviewer claims: claude-sonnet-5-5 19 s $0.0842
- fix 2 implementer: claude-sonnet-5-5 58 s $0.0785
- review fix-check reviewer: claude-sonnet-5-5 19 s $0.0667
Finding outcomes: {"fixed":4}. Classes: {"ADR index must point narrowed ADRs at replacement":1,"contradicts accepted ADR without narrowing":3}.
{
 "findings": [
  {
   "id": "R1",
   "role": "spec",
   "class": "contradicts accepted ADR without narrowing",
   "outcome": "fixed",
   "path": "docs/internal/adr/0046-a-standalone-worker-serves-agent-device-by-default-with-a-private-profile.md",
   "round": "1",
   "fix": "ebba7efd3"
  },
  {
   "id": "R2",
   "role": "spec",
   "class": "contradicts accepted ADR without narrowing",
   "outcome": "fixed",
   "path": "docs/internal/adr/0046-a-standalone-worker-serves-agent-device-by-default-with-a-private-profile.md",
   "round": "1",
   "fix": "ebba7efd3"
  },
  {
   "id": "R3",
   "role": "spec",
   "class": "ADR index must point narrowed ADRs at replacement",
   "outcome": "fixed",
   "path": "docs/internal/adr/README.md",
   "round": "1",
   "fix": "ebba7efd3"
  },
  {
   "id": "R4",
   "role": "spec",
   "class": "contradicts accepted ADR without narrowing",
   "outcome": "fixed",
   "path": "docs/internal/adr/0046-a-standalone-worker-serves-agent-device-by-default-with-a-private-profile.md",
   "round": "2",
   "fix": "7582ef8be"
  }
 ]
}

Written by an agent.

@V3RON
V3RON added this pull request to stack #965 October 23, 2026 20:04
@V3RON
V3RON merged commit f3727eb into main Oct 24, 2026
46 of 47 checks passed
@V3RON
V3RON deleted the feature/952-adr branch October 24, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant