Repository navigation
Conversation
Contributor
Author
Review ledger{"findings":[
{"id":"R1","role":"code","class":"testing 10","outcome":"open","path":"ui/src/model/search.test.ts"},
{"id":"R2","role":"code","class":"spec line undelivered","outcome":"open","path":"ui/src/model/search.ts"},
{"id":"R3","role":"claims","class":"claim false (Actions waits for tokens)","outcome":"open","path":"docs/CONSOLE.md"},
{"id":"R4","role":"claims","class":"claim false (mono label)","outcome":"open","path":"docs/internal/DESIGN.md"},
{"id":"R5","role":"code","class":"spec line undelivered","outcome":"nonblocking","path":"ui/src/state/search.ts"}
]}
Written by an agent. |
V3RON
marked this pull request as ready for review
October 21, 2026 13:28
…tton opens it too; Escape closes it and focus returns (#770)
…o /fleet/<id>; a device result opens /fleet/<workerId>/<deviceId>; a lease result opens /leases/<id>; a request result opens /queue/<id> (#770)
…d lists the actions the menus offer (#770)
…do; release, cancel and remove ask the menu's confirms (#770)
… in while the highlight stays; a failing /v1/workers says Could not load workers. (#770)
…light stays on its result (#770)
… or the highlight (#770)
…<style> element or CSP violation (#770)
…ge lay out without gaps (#770) - Drawer: slides in from the right edge with the dim layer fading in; a soft edge and shadow replace the bright border and the focus ring round the whole panel. - Icons: square line ends, so the ⋯ dots and the device and worker dots draw. - Charts: the minute-by-minute disclosure goes; the numbers stay as a table only a screen reader reads. The summary's Now is the newest bucket with a figure, not —. - Overview: Needs you is always a panel (Nothing needs you inside it) beside Capacity; the two charts share a row; Workers takes the full width. Capacity bars show the room left as free. A worker named by its id is one line, cut, with the id in its title. - Stat tiles keep a figure on one line. - Usage: Durations and Use over the range take a whole row each, after the count tables.
…with one row (#770) - The main area fills the window; a table's card (table and pager) or Activity's feed, as the page's last part, takes the height left. - The hidden minute table hides on a wrapper: a table grows to its rows whatever its height. - The feed asks for older events once per number of rows, so its box settling to the page's height does not send the same request twice.
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #770
Status
Implement: done (208/208 Chromium console lane at build; 479/479 ui unit after fixes) Review: round 1, 4 fixes and 1 note applied; one round by the maintainer's call Hardware: n/a Gate: waiting for the stack
Audit: stopped early on the maintainer's call; no audit commits.
Done when
pnpm test:console --project=chromiumpasses, and CI's Console check passes in every browser. Checked: Chromium locally; other browsers in CI.Assumptions
ds/command-palette.tsxinside Base UI's Dialog, keeping the highlight by result id.role=dialogoralertdialognot markedaria-modal="false"(a toast is such a dialog and does not block).e2e/console/shell.spec.ts's keyboard tour lists the new "Search or jump to…" button first in the sidebar, and the search specs wait for a closing dialog to leave before the next ⌘K — setup only, no claim changed.Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 2 blocking, 2 fixed, 1 notes. Claims review: 2 blocking, 2 fixed, 0 notes.
Rounds: 1. Tokens: 19.6M.
Runs: 7. Cost USD: 5.3958. Agent seconds: 4749.
Assessment: complete
Written by an agent.