Skip to content

feat(console): search or jump to anything with ⌘K - #834

Merged
V3RON merged 32 commits into
task/769from
task/770
Oct 21, 2026
Merged

V3RON merged 32 commits into
task/769from
task/770

Conversation

@V3RON

@V3RON V3RON commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Closes #770

Status

Implement: done (208/208 Chromium console lane at build; 479/479 ui unit after fixes) Review: round 1, 4 fixes and 1 note applied; one round by the maintainer's call Hardware: n/a Gate: waiting for the stack

Audit: stopped early on the maintainer's call; no audit commits.

Done when

  • pnpm test:console --project=chromium passes, and CI's Console check passes in every browser. Checked: Chromium locally; other browsers in CI.

Assumptions

  • Assumption: the palette's listbox — Base UI's Autocomplete highlights by index and resets it whenever the items change, which would move the highlight when a group fills in — the listbox and combobox are written in ds/command-palette.tsx inside Base UI's Dialog, keeping the highlight by result id.
  • Assumption: which dialogs block ⌘K — any role=dialog or alertdialog not marked aria-modal="false" (a toast is such a dialog and does not block).
  • Assumption: Leases wait for the tokens and workers that name them, and Actions for the tokens too, before they leave "Loading…" — so a label never changes after it shows.
  • Assumption: a route a single host answers 501 lists nothing instead of "Could not load" — the conservative match to how the Inbox treats it.
  • Assumption: e2e/console/shell.spec.ts's keyboard tour lists the new "Search or jump to…" button first in the sidebar, and the search specs wait for a closing dialog to leave before the next ⌘K — setup only, no claim changed.

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 2 blocking, 2 fixed, 1 notes. Claims review: 2 blocking, 2 fixed, 0 notes.
Rounds: 1. Tokens: 19.6M.
Runs: 7. Cost USD: 5.3958. Agent seconds: 4749.
Assessment: complete

Written by an agent.

@V3RON

V3RON commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Runs: 7. Cost USD: 5.3958. Agent seconds: 4749.
Tokens input 340, output 126021, cache read 15594439, cache write 809991.
- build implementer: claude-sonnet-5-5 3124 s $3.0248
- audit implementer: claude-sonnet-5-5 739 s $0.4515
- review 1 reviewer: claude-sonnet-5-5 341 s $0.1545
- review 1 spec: claude-sonnet-5-5 51 s $0.2465
- review 1 code both: claude-opus-5-5 264 s $1.1009
- review 1 claims: claude-sonnet-5-5 53 s $0.1875
- fix 1 implementer: claude-sonnet-5-5 177 s $0.2301
Finding outcomes: {"nonblocking":1,"open":4}. Classes: {"claim false (Actions waits for tokens)":1,"claim false (mono label)":1,"spec line undelivered":2,"testing 10":1}.
{"findings":[
{"id":"R1","role":"code","class":"testing 10","outcome":"open","path":"ui/src/model/search.test.ts"},
{"id":"R2","role":"code","class":"spec line undelivered","outcome":"open","path":"ui/src/model/search.ts"},
{"id":"R3","role":"claims","class":"claim false (Actions waits for tokens)","outcome":"open","path":"docs/CONSOLE.md"},
{"id":"R4","role":"claims","class":"claim false (mono label)","outcome":"open","path":"docs/internal/DESIGN.md"},
{"id":"R5","role":"code","class":"spec line undelivered","outcome":"nonblocking","path":"ui/src/state/search.ts"}
]}

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 21, 2026 13:28
@V3RON
V3RON added this pull request to stack #781 October 21, 2026 13:28
V3RON added 21 commits October 21, 2026 15:43
…tton opens it too; Escape closes it and focus returns (#770)
…o /fleet/<id>; a device result opens /fleet/<workerId>/<deviceId>; a lease result opens /leases/<id>; a request result opens /queue/<id> (#770)
…do; release, cancel and remove ask the menu's confirms (#770)
… in while the highlight stays; a failing /v1/workers says Could not load workers. (#770)
V3RON added 4 commits October 21, 2026 16:18
…ge lay out without gaps (#770)

- Drawer: slides in from the right edge with the dim layer fading in; a soft edge and shadow
  replace the bright border and the focus ring round the whole panel.
- Icons: square line ends, so the ⋯ dots and the device and worker dots draw.
- Charts: the minute-by-minute disclosure goes; the numbers stay as a table only a screen reader
  reads. The summary's Now is the newest bucket with a figure, not —.
- Overview: Needs you is always a panel (Nothing needs you inside it) beside Capacity; the two
  charts share a row; Workers takes the full width. Capacity bars show the room left as free.
  A worker named by its id is one line, cut, with the id in its title.
- Stat tiles keep a figure on one line.
- Usage: Durations and Use over the range take a whole row each, after the count tables.
…with one row (#770)

- The main area fills the window; a table's card (table and pager) or Activity's feed, as the
  page's last part, takes the height left.
- The hidden minute table hides on a wrapper: a table grows to its rows whatever its height.
- The feed asks for older events once per number of rows, so its box settling to the page's
  height does not send the same request twice.
@V3RON
V3RON merged commit 7b5b4d9 into main Oct 21, 2026
22 of 26 checks passed
@V3RON
V3RON deleted the task/770 branch October 21, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console: ⌘K search or jump to

1 participant