Repository navigation
feat(daemon): a worker with real drivers holds a per-user lock - #1193
Merged
Merged
Conversation
Contributor
Author
Review ledgerRound 1: 301ccc3 {"findings":[{"id":"R1","role":"code","class":"testing 10","outcome":"fixed","path":"src/daemon/main.test.ts","round":"1","fix":"382997c9e"},{"id":"R2","role":"code","class":"ownership assumed","outcome":"fixed","path":"src/ports/worker-lock.ts","round":"1","fix":"9b0a8166b73"},{"id":"R3","role":"code","class":"testing 3","outcome":"fixed","path":"src/daemon/main.test.ts","round":"1","fix":"382997c9e"},{"id":"R4","role":"claims","class":"flow missing lock steps","outcome":"fixed","path":"docs/internal/flows/startup.md","round":"1","fix":"86777ac90"},{"id":"R5","role":"code","class":"ownership assumed","outcome":"duplicate","path":"src/ports/worker-lock.ts","round":"2","canonicalId":"R2","fix":"9b0a8166b73"}]}Written by an agent. |
V3RON
marked this pull request as ready for review
November 2, 2026 11:08
V3RON
added a commit
that referenced
this pull request
Nov 2, 2026
…) (#1190) ADR 0059 for #1189, Accepted — not yet implemented. A worker that runs real drivers takes a per-user lock (`/tmp/simlock-<uid>/worker.lock/`, holding pid, folder and start time) before it discovers drivers. A second real-driver worker of the same user with another folder refuses to start and names the first. Workers with substituted drivers (the fast e2e lane, the gateway-fleet tests) and gateways never take it. It narrows ADR 0034 §1's "No new lock is needed" and ends bug #264 for one user. This PR is the bottom of #1189's stack and merges with the feature's last task. ## Status Review: round 1 3 blocking, round 2 1 blocking, fix-check passed (R1–R3 fixed) Gate: waiting for the stack Next: stack with #1193 ## Review Spec review: 4 blocking, 4 fixed, 1 notes. Code review: skipped. Claims review: skipped. Rounds: 2. Tokens: 6.6M. Runs: 7. Cost USD: 2.3004. Agent seconds: 759. Assessment: complete *Written by an agent.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1191
Status
Implement: done Review: passed (R1–R4 fixed, R5 dup) Hardware: pass ADR 0059: Accepted (adr-flip-check ok) Gate: not run — merge needs the maintainer's permission
Next: .agents/scripts/merge-pr.sh 1193 (gates and merges #1190 and #1193)
Assumptions
Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 4 blocking, 4 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 2. Tokens: 11.9M.
Runs: 20. Cost USD: 8.9458. Agent seconds: 4414.
Assessment: complete
Done when
pnpm exec vitest run --project unit src/daemon/main.test.ts src/ports/worker-lock.test.ts src/slow-e2e.test.tspasses, with the lines above. — run by the build, audit and fix runs; CI Unit tests on the heade2e/slow-android-smoke.test.tschecks that/tmp/simlock-<uid>/worker.lock/owner.jsonnames its worker's pid and folder while it runs, and is gone aftersimlock daemon stop. — hardware verifier pass at f3dced3 (log simlock-slow-e2e-20261102-120326.log)pnpm test:e2epasses with its files in parallel (F11). — CI E2E jobs on the headrunning-the-daemon.mdxno longer offers a second worker throughSIMLOCK_HOME, and says a second worker refuses to start and names the first. — spec and claims review, round 1adr: 0059 to Acceptedfix run on this branch, adr-flip-checkpnpm test:e2estill runs its files in parallel and passes. — CI E2E jobs on the headscripts/slow-e2e.shexits 69 naming the holder while a worker outside the lane holds the lock. — src/slow-e2e.test.tsworker/running-the-daemon.mdxno longer offers a separate install withSIMLOCK_HOME. — claims review, round 1Written by an agent.