Skip to content

Five console tests each wait up to a minute of wall clock for a usage minute to close #865

Closed

Description

@V3RON

scriptedRun in e2e/console/overview.spec.ts:61-80 and e2e/console/usage.spec.ts:65-84 waits until the wall-clock minute the run started in is over (minuteOver, lines 71-72 and 78-79), because /v1/stats charts closed minutes only. Five tests call it: overview.spec.ts:123, :153, :174, :282 and usage.spec.ts:131.

They are about a quarter of the console lane's test time, in every browser:

CI main 1680c5c1, Chromium:  54.4 s, 59.3 s, 1.1 min, 41.5 s, 49.0 s  = ~270 s of 976 s
local main, Chromium:        45.1 s, 59.8 s, 1.1 min, 48.4 s, 22.4 s

They arrived with #626, the first main run whose Console job timed out (60521f0). Sharing one scripted run per file, or a way to close a minute without waiting, would cut most of it.

Found while triaging #852.

Written by an agent.

Activity

  1. added
    bug:newReported. An agent may triage it (rule 8), and nothing more.
    and removed
    bug:newReported. An agent may triage it (rule 8), and nothing more.
    on Oct 22, 2026
  2. self-assigned this
    on Oct 23, 2026
  3. V3RON commented on Oct 23, 2026

    @V3RON
    ContributorAuthor

    Does not reproduce on main (cac23e0): #883 (3ca05c5) already fixed it. Recommend closing as fixed.

    scriptedRun no longer waits for a minute to close. The five tests call host.prepareHistoricalUsage() (e2e/console/fixtures.ts:394) instead: it stops the daemon, shifts the history.db minute rows back two minutes, and starts the daemon again. minuteOver is gone from e2e/.

    The five tests now take 5 to 13 s each, down from 41 to 66 s:

    pnpm test:console --project=chromium e2e/console/overview.spec.ts e2e/console/usage.spec.ts
    overview.spec.ts:110  7.2s   (was :123, 54.4 s)
    overview.spec.ts:141  5.5s   (was :153, 59.3 s)
    overview.spec.ts:163 13.2s   (was :174, 1.1 min)
    overview.spec.ts:272  5.4s   (was :282, 41.5 s)
    usage.spec.ts:124     7.7s   (was :131, 49.0 s)
    19 passed (1.5m)
    

    To reopen this I would need a console run on main where one of these tests still takes more than about 20 s, with its trace.

    Written by an agent.

  4. added
    bug:needs-infoCould not reproduce. Waiting on the reporter.
    and removed on Oct 23, 2026
  5. removed their assignment
    on Oct 23, 2026
  6. V3RON commented on Oct 23, 2026

    @V3RON
    ContributorAuthor

    Fixed by #883 (3ca05c5): the five tests no longer wait for a wall-clock minute to close.

    Written by an agent.

  7. removed
    bug:needs-infoCould not reproduce. Waiting on the reporter.
    on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions