You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Console search.spec.ts:139 and :263 fail on main in Chromium (local run) #864
On main at 1680c5c, pnpm test:console --project=chromium --workers=2 (one local run, macOS, 12 cores) failed two search tests that CI's Chromium pass at the same commit did not:
search.spec.ts:139 › a live update while the dialog is open changes neither the list nor the highlight, and reopening builds the list again
expect(locator).toHaveText at search.spec.ts:154
Expected: "nav-waiter · iOS iPhone 16, runtime 18.4"
Received: "Cancel request — nav-waiter · iOS iPhone 16, runtime 18.4"
search.spec.ts:263 › an action runs as from its menu: drain ..., release and cancel ..., remove ...
expect(getByRole('dialog', { name: 'Search' })).toBeHidden() at search.spec.ts:286 (called from :308)
Received: visible
Not rerun, so flaky or not is unknown. Activity:371 and Queue:163 failed in the same run; those are #853.
Fixed on main by #882 (8680c0f), a test-only change. Both failures were test defects, not console bugs. Recommend closing. No repro branch, since no test fails on main.
main 7a2f0b33, current spec, Chromium, --workers=4 --repeat-each=5, whole file: 40/40 pass
plus :282 alone, --workers=2 --repeat-each=10: 10/10 pass
1680c5c1's spec against main's console, --workers=4 --repeat-each=10: 6/20 fail
search.spec.ts:286 expect(getByRole('dialog', { name: 'Search' })).toBeHidden() Received: visible
(called from :290 "drain live-b" x2, :308 "release nav-holder" x3)
search.spec.ts:151 expect(before).toHaveLength(4) Received length: 0
Root cause
Test defect in e2e/console/search.spec.ts at 1680c5c, lines 150-154 and 284-286. The console works as ui/AGENTS.md (Search) describes. The list fills in group by group as each read settles. The highlight stays on the first result present at that moment (ui/src/ds/command-palette.tsx:22-26). Enter with nothing highlighted does nothing (:85). The old tests read the options, or pressed Enter, right after fill(), before the groups loaded. So before[1] named whatever result was second at that point ("Cancel request — nav-waiter" in the report). And Enter ran before the typed result was there, so the dialog stayed open. #882 waits for the groups and for a highlight that matches the typed text before reading or pressing Enter.
Closing as fixed by #882 (8680c0f): the triage report above shows both failures were test races (acting before the result list filled), and the current spec passes 50/50 on main.
Activity
test: wait for Console semantic state (#882)
V3RON commentedon Oct 24, 2026
Reproduction
Fixed on
mainby #882 (8680c0f), a test-only change. Both failures were test defects, not console bugs. Recommend closing. No repro branch, since no test fails onmain.Root cause
Test defect in
e2e/console/search.spec.tsat 1680c5c, lines 150-154 and 284-286. The console works asui/AGENTS.md(Search) describes. The list fills in group by group as each read settles. The highlight stays on the first result present at that moment (ui/src/ds/command-palette.tsx:22-26). Enter with nothing highlighted does nothing (:85). The old tests read the options, or pressed Enter, right afterfill(), before the groups loaded. Sobefore[1]named whatever result was second at that point ("Cancel request — nav-waiter" in the report). And Enter ran before the typed result was there, so the dialog stayed open. #882 waits for the groups and for a highlight that matches the typed text before reading or pressing Enter.Simplest fix
None needed: #882 is the fix. Close as fixed.
Alternatives rejected
Risk
fill()share the race; test: wait for Console semantic state #882 covered the ones it found (11 specs).Written by an agent.
V3RON commentedon Oct 24, 2026
Closing as fixed by #882 (8680c0f): the triage report above shows both failures were test races (acting before the result list filled), and the current spec passes 50/50 on main.
Written by an agent.