Repository navigation
Download-limit test receives fewer than 2 GiB before abort on main #807
Description
What happens
src/agent-device/gateway-front.test.ts:2293, “a download with no content-length that passes 2147483648 bytes errors the agent's response, which never ends cleanly”, fails its delivered-byte assertion at line 2319. The response aborts, but the reader receives slightly less than the asserted 2 GiB.
Reproduction evidence
Found during #802 build validation; confirmed before that change on origin/main commit d8404072da2ef7ac823c0269d1b987d20a040c62 using an isolated git archive snapshot and the repository's dependency preparation script.
pnpm exec vitest run --project unit src/agent-device/gateway-front.test.tsBase result: 73 passed, 1 failed. Named assertion:
AssertionError: expected 2145320960 to be greater than or equal to 2147483648
src/agent-device/gateway-front.test.ts:2319:25
On bug/802 head 5a809a18967d5934d0e287e6b5d7866f94158646, pnpm test:changed failed the same assertion with 2144993280 bytes delivered; 5115 passed and 2 skipped. The branch's affected leasing and warm-pool suites separately pass all 362 tests.
Scope and uncertainty
The failure predates #802. No root cause or fix is established. Investigate whether aborting the oversized stream can discard bytes buffered before the agent reads them, and whether this assertion promises more than the stream contract guarantees. Do not disable or weaken the test without deciding the intended behavior.
Written by an agent.
Activity
fix(warm-pool): protect devices serving queued requests (#804)
test(audit): drop the gateway-front 2 GiB download tests
test(audit): remove low-value tests across the suite, 140 fewer tests (…
feat(agent-device): --os and --image-tag reach lease.request (#840)
feat(warm-pool): status, doctor, console and docs show learned kinds …
fix(startup): reject daemon sockets closed before hello (#805)
feat(contract): move to Zod 4 (#845)
test(agent-device): drop download-cap.test.ts (#862)
V3RON commentedon Oct 25, 2026
Decision
Maintainer: test-only fix. The cap aborts the stream, and bytes still buffered can be dropped, so "at least 2 GiB delivered" is not part of the contract. The test asserts that the agent's response errors, never ends cleanly, and never delivers more than 2147483648 bytes. No product change.
Written by an agent.
test(agent-device): title states the delivered-bytes bound (#807)
V3RON commentedon Oct 25, 2026
Delivery run
Merged: #988 (#807)
Parked: none
Waiting: none
Decided: none (the fix followed the maintainer's Decision; the gateway-front.test.ts test the issue names was already removed in #849, so the change asserts the upper bound in edge.test.ts's equivalent test)
Written by an agent.