Skip to content

daemon start hides the config error when the daemon fails to boot #542

Closed

Description

@V3RON

What happens

When the daemon cannot boot because of a config error (for example a worker config with android.maxDevices: 0), simlock daemon start waits 5 seconds and prints only Timed out starting simlock daemon: connect ENOENT .../daemon.sock. The real ConfigError is written only to daemon.log.

What should happen

Before the CLI launches a daemon, it loads the config the daemon would load. If that fails, the command prints the ConfigError message and exits 1 at once, without launching anything. This covers every command that auto-starts the daemon, not only daemon start.

Done when

  • simlock daemon start with an invalid config.json exits 1 at once with the ConfigError message on stderr, and launches no daemon.
  • docs/CLI.md no longer says the error line hides the reason.

Tests: a CLI unit test in src/cli/index.test.ts that runs daemon start against a config with android.maxDevices: 0 and asserts the message, exit 1 and zero launches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug:readyAn agent may fix it.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions