Skip to content

feat(android): 🌟 add support for React Native 0.73#195

Merged
Naturalclar merged 1 commit intocallstack:masterfrom
ngocle2497:master
Jun 20, 2023
Merged

feat(android): 🌟 add support for React Native 0.73#195
Naturalclar merged 1 commit intocallstack:masterfrom
ngocle2497:master

Conversation

@ngocle2497
Copy link
Copy Markdown
Contributor

Summary

Starting from React Native v0.73 , all libraries will need to be updated with these two one-liners due to Android Gradle Plugin upgrade
discussions-671

Compatibility

OS Implemented
iOS
Android

Copy link
Copy Markdown
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Naturalclar Naturalclar merged commit 2923dee into callstack:master Jun 20, 2023
@ngocle2497
Copy link
Copy Markdown
Contributor Author

@Naturalclar this change will not work on RN < 0.71. comment.
So we need to keep package in the manifest util find new solution to remove package prop when RN < 0.71

@Naturalclar
Copy link
Copy Markdown
Contributor

@MasonLe2497 thanks for the comment! I'm aware that this change won't work on RN < 0.71
I was thinking of publishing the package as a major update (1.0.0) with changes in #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants