Skip to content

Use deprecate-react-native-prop-types#166

Closed
irmakcosarsahna wants to merge 1 commit intocallstack:masterfrom
irmakcosarsahna:patch-4
Closed

Use deprecate-react-native-prop-types#166
irmakcosarsahna wants to merge 1 commit intocallstack:masterfrom
irmakcosarsahna:patch-4

Conversation

@irmakcosarsahna
Copy link
Copy Markdown

Platforms affected
All

What does this PR do?
RN 0.68 has deprecated and will eventually remove ViewPropTypes (see post). This adds the deprecated-react-native-prop-types package and uses that instead.

What testing has been done on this change?
Local testing, to ensure the deprecation warning has been removed.

@Naturalclar
Copy link
Copy Markdown
Contributor

@irmakcosarsahna thanks for the PR
I think it's better to remove the deprecated props altogether rather than replace the type with deprecated-react-native-prop-types, since using the deprecated types also will remove backwards compatability with older react-native versions

@Naturalclar
Copy link
Copy Markdown
Contributor

Will close this PR in favor of #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants