Repository navigation
chore(gates): assign the daemon files that landed beside the R81 manifest - #3412
Merged
Merged
Conversation
…fest #3391 added the daemon layer manifest while #3403 and #3404 were in flight, and each merged green on its own: src/daemon/platform-services.ts and src/daemon/device/claim-recovery-gateway.ts reached main in no layer, so R81 fails on main and every PR's Repo Guards. platform-services.ts fits only daemon-core; the claim-recovery port fits any layer and goes in daemon-resources beside the device claims, matching the assignment #3395 already carries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Size Report
Startup median (7 runs, lower is better):
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Member
Author
|
This looks good at 811cf84. The change only assigns the new daemon files in scripts/layering/daemon-layer-manifest.json, and I found nothing to fix. The Smoke Tests job is still running. The diff only touches the layering manifest, which the device smoke route does not read, so I expect no overlap. I did not run the daemon-layers gate locally, and I did not compare the assignments against #3395. I also did not look for other unassigned daemon files, but the layering check would report any. No conflicts. The only thing left before merge is the Smoke Tests run finishing green. |
thymikee
added
the
ready-for-human
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R81 fails on main (and in every PR's Repo Guards, e.g. #3408). #3391 added the daemon layer manifest while #3403 and #3404 were still open. Each passed CI on its own, but together
src/daemon/platform-services.tsandsrc/daemon/device/claim-recovery-gateway.tsreached main without a layer.platform-services.ts→daemon-core, the only layer R81 accepts for it.claim-recovery-gateway.ts→daemon-resources. It's a type-only port that fits any layer; this matches the assignment refactor(move): extract the daemon-contracts zone into packages/daemon-contracts #3395 already carries, so the two PRs don't conflict.1 file, +2.
Validation
Tested
811cf84b8on main59d00bed3:pnpm check:affected --runpassed (full set, selected by the gate-manifest change).pnpm check:layeringfails on main and passes here. Before choosing the layers, I tried every layer pair against the R81 test.🤖 Generated with Claude Code