Skip to content

CRAP follow-ups: test-quality fixes from child PR reviews #3461

Closed

Description

@thymikee

Purpose

The maintainer's reviews of the merged CRAP burn-down child PRs (#3414) left take-or-leave test-quality suggestions. This issue keeps the ones that catch a real regression or remove flakiness, and drops the purely cosmetic ones (casts, PR-body counts, import style). Each retained item must name the regression it would catch.

Area 1: client and perf-capture tests (#3429, #3432) — #3463

Area 2: Android, Linux and Apple tests (#3433, #3434, #3435) — #3462

Dropped as cosmetic: inline import(...) types and the double cast in the perf-capture test, fallow-crap.json comment wording, createCompanionBridgeServer migration of older tests (separate refactor), and PR-body line counts.

Completion

  • Tests only, through public entry points, with no production changes, no new exports and no test-only DI. Each PR ≤ 1,000 gross lines.
  • pnpm check:affected --run passes on the pushed head.

Part of #3414.

Activity

  1. thymikee commented on Oct 12, 2026

    @thymikee
    MemberAuthor

    Both areas merged: #3463 (client and perf-capture tests) and #3462 (Android, Linux and Apple tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions