Repository navigation
CRAP: shared packages (capture-kit diffing and overlay, maestro, selectors, limrun) #3423
Description
Purpose
Burn down part of the coverage-based CRAP list from #3414.
Findings (main 5f84627d8)
| Function | CRAP | CC | Coverage |
|---|---|---|---|
packages/capture-kit/src/png-rgb-difference.ts:19 computePngRgbDifference |
42 | 6 | 0% |
packages/capture-kit/src/react-native-overlay.ts:266 collapsedWarningScores |
30 | 5 | 0% |
packages/maestro/src/internal/facade-execution.ts:273 suggestionQuery |
62 | 14 | 38% |
packages/selectors/src/index.ts:150 values |
30 | 5 | 0% |
packages/provider-limrun/src/runtime.ts:501 getAppState |
30 | 5 | 0% |
Owned files
packages/capture-kit/src/png-rgb-difference.tspackages/capture-kit/src/react-native-overlay.tspackages/maestro/src/internal/facade-execution.tspackages/selectors/src/index.tspackages/provider-limrun/src/runtime.ts
Notes
suggestionQuery (CC 14, 38%) may also need a split. Child A owns png-worker.ts in capture-kit; name any new fixture after the module it serves.
Completion
- Every function above is absent from
pnpm check:coverage-crap --allon the PR head (score < 30), or is exempted where this issue says so. - Tests go through the owning module's public entry point. No new production exports for tests and no test-only DI (
docs/agents/testing.md). - Only the owned files, the tests that exercise them, and
*.fixtures.tshelpers change. The PR stays under the 1,000-line gross budget, andpnpm check:affected --runpasses on the pushed head.
Part of #3414.
Activity
test(capture-kit,maestro,selectors,provider-limrun): cover shared-pac…