Skip to content

CRAP: platform-apple core (launch diagnostics, CoreDevice, install artifact) #3417

Closed

Description

@thymikee

Purpose

Burn down part of the coverage-based CRAP list from #3414.

Findings (main 5f84627d8)

Function CRAP CC Coverage
packages/platform-apple/src/core/launch-diagnostics.ts:31 probeSimulatorLaunchContext 56 7 0%
packages/platform-apple/src/core/physical-device-coredevice.ts:95 normalizeCoreDeviceProbeError 56 7 0%
packages/platform-apple/src/core/physical-device-coredevice.ts:86 normalizeCoreDeviceReadyError 42 6 0%
packages/platform-apple/src/core/physical-device-files.ts:8 copyCoreDeviceRunnerFile 30 5 0%
packages/platform-apple/src/core/install-artifact.ts:210 resolveIosPayloadBundleByHint 30 5 0%

Owned files

  • packages/platform-apple/src/core/launch-diagnostics.ts
  • packages/platform-apple/src/core/physical-device-coredevice.ts
  • packages/platform-apple/src/core/physical-device-files.ts
  • packages/platform-apple/src/core/install-artifact.ts

Notes

All at 0%. Most are error normalization and diagnostics, so table-driven tests over their inputs should clear them.

Completion

  • Every function above is absent from pnpm check:coverage-crap --all on the PR head (score < 30), or is exempted where this issue says so.
  • Tests go through the owning module's public entry point. No new production exports for tests and no test-only DI (docs/agents/testing.md).
  • Only the owned files, the tests that exercise them, and *.fixtures.ts helpers change. The PR stays under the 1,000-line gross budget, and pnpm check:affected --run passes on the pushed head.

Part of #3414.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions