You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(ios-runner): TS runner retry rules keyed on self-produced message text → typed reasons #2787
packages/platform-apple/src/runner/runner-contract.ts:330-394 decides runner retries with seven messageIncludesAll rules (:346-394). Some of them match messages that agent-device writes itself:
'runner did not accept connection' (runner-contract.ts:842/867, runner-startup-transport.ts:440/443)
AGENTS.md forbids keying behavior on message text. Line references are at 01328de411.
Required behavior
Every error that agent-device itself produces and that a retry rule depends on carries a typed details.reason at the place it is produced. The rule matches that reason.
Rules that match text from external tools (xcodebuild or simctl output) may keep matching text, but only against the captured tool output field, and each needs a one-line comment naming the tool. List them in the PR.
Retry outcomes do not change for any existing case.
Completion conditions
The existing runner-contract retry tests pass unchanged. Add one test per converted rule that asserts the typed reason drives the decision, including when the message text changes.
Activity