You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor: one shellQuote implementation instead of three #2525
Three byte-identical shellQuote bodies (verified at eefe37b51e):
packages/host-kit/src/internal/shell-quote.ts (canonical; exported via @agent-device/host-kit/command, command.ts:25)
packages/platform-android/src/perf-native-artifacts.ts:124 (exported; used at :143, :208; imported by perf-native-simpleperf.ts:8)
packages/platform-apple/src/runner/runner-lease.ts:292 (used by formatEnvAssignment, a human hint string)
platform-android already imports shellQuoteIfNeeded from @agent-device/host-kit/command in three sibling files, so the Android copy is a direct import swap. R77 (scripts/layering/apple-runner-host-port-policy.ts) forbids runner/** from value-importing host-kit, so the Apple copy goes through the AppleRunnerHost port (runner/host.ts, bound in core/runner-host.ts). Do not take the "runner-local const" shortcut.
Note: the adb-shell injection gap from the 2026-08-06 audit is already closed (057f0e6eb1e, 6dd7d406c04); this issue is duplication only.
Done when
grep -rn "replaceAll(\"'\"" packages src finds one implementation. Unit tests only; no device run needed.
Activity
thymikee commentedon Sep 12, 2026
Part of #2531.
refactor(shell-quote): one implementation, reached through the runner…