Skip to content

Conversation

@ADmad
Copy link
Member

@ADmad ADmad commented Jan 29, 2026

No description provided.

@ADmad ADmad added this to the 4.x milestone Jan 29, 2026
@ADmad ADmad requested a review from markstory January 29, 2026 16:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the Identity::get() method to support dot-separated field names for accessing nested data, aligning its functionality with the existing IdentityHelper::get() pattern. The method signature is updated to make the field parameter optional, allowing retrieval of the entire identity data when called without arguments.

Changes:

  • Modified Identity::get() to accept nullable field parameter and use Hash::get() for dot notation support
  • Added cakephp/utility package as a required dependency for the Hash utility class
  • Added comprehensive test coverage for the new dot notation functionality

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/Identity.php Updated get() method signature to accept optional field parameter and replaced direct array access with Hash::get() for dot notation support
tests/TestCase/IdentityTest.php Added new test method testGet() to verify dot notation functionality with Entity objects
composer.json Added cakephp/utility ^5.0 as a required dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Jan 30, 2026

@ADmad I've opened a new pull request, #769, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants