Skip to content

Add NodeReuse property to DotNetMSBuildSettings#4194

Merged
augustoproiete merged 2 commits into
cake-build:developfrom
Marusyk:rmarusyk/4144
Sep 29, 2023
Merged

Add NodeReuse property to DotNetMSBuildSettings#4194
augustoproiete merged 2 commits into
cake-build:developfrom
Marusyk:rmarusyk/4144

Conversation

@Marusyk

@Marusyk Marusyk commented Jul 16, 2023

Copy link
Copy Markdown
Contributor

Add NodeReuse property to DotNetMSBuildSettings and tests

Fixes #4144

Please review,
Thank you in advance

@augustoproiete augustoproiete left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Small change on the command-line

Comment thread src/Cake.Common.Tests/Unit/Tools/DotNet/MSBuild/DotNetMSBuildBuilderTests.cs Outdated

@augustoproiete augustoproiete left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustoproiete augustoproiete enabled auto-merge July 16, 2023 07:29
@alexrp

alexrp commented Aug 5, 2023

Copy link
Copy Markdown

@augustoproiete seems like this one somehow got stuck pending approval despite having approval? 🤔

@devlead devlead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@augustoproiete augustoproiete merged commit 4682b35 into cake-build:develop Sep 29, 2023
@devlead

devlead commented Sep 29, 2023

Copy link
Copy Markdown
Member

@Marusyk your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DotNetMSBuildSettings is missing NodeReuse

4 participants