(#3858, #3859) Made PathCollapser aware of different formats#3865
Merged
Conversation
This was
linked to
issues
Apr 7, 2022
devlead
requested changes
Apr 8, 2022
especially different calculations of the root of a path
for windows, non-windows and UNC like paths.
To this end, I re-structured the unit test. There were no test
removed that previously existed, but only new tests added.
Also, instead of joining together the path with one specific
separator ('/'), I re-used the existing separator of the original
path. (This was the main-fix for #3859.)
Member
|
@nils-a your changes have been merged, thanks for your contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially different calculations of the root of a path
for windows, non-windows and UNC like paths.
To this end, I re-structured the unit test. There were no test
removed that previously existed, but only new tests added.
Also, instead of joining together the path with one specific
separator ('/'), I re-used the existing separator of the original
path. (This was the main-fix for #3859.)