GH3627, GH3628, GH3629, GH3630, GH3631: Refactor GitHub Actions Provider#3632
Merged
devlead merged 1 commit intoNov 4, 2021
Conversation
devlead
commented
Oct 25, 2021
devlead
commented
Member
- Adds GitHub Actions Commands
- AddPath, fixes Add GitHub Actions AddPath Command #3627
- SetEnvironmentVariable, fixes Add GitHub Actions SetEnvironmentVariable Command #3628
- UploadArtifact, fixes Add GitHub Actions UploadArtifact Command #3629
- Adds GitHub Actions
- Runtime Info
- Runner Name
- Workflow ActionPath
- fixes Add GitHub Actions Environment properties #3630
- Refactors GitHub Actions Paths, fixes Refactor GitHub Actions Paths #3631
- Initial work on BuildSystem integration tests
- Adds GitHub Actions Commands integration tests
augustoproiete
requested changes
Oct 25, 2021
augustoproiete
left a comment
augustoproiete
left a comment
Member
There was a problem hiding this comment.
LGTM. Will do a more thorough review later
devlead
force-pushed
the
feature/gh-3627/gh-3628/gh-3629/gh-3630/gh-3631
branch
7 times, most recently
from
ac13334 to
0334ea1
Compare
devlead
force-pushed
the
feature/gh-3627/gh-3628/gh-3629/gh-3630/gh-3631
branch
2 times, most recently
from
ebc4cc4 to
f6d30c2
Compare
nils-a
approved these changes
Nov 4, 2021
nils-a
left a comment
nils-a
left a comment
Member
There was a problem hiding this comment.
Not able to take this for a spin currently, but all changes LGTM!
…-build#3631) Refactor GHA * Adds GitHub Actions Commands * AddPath, fixes cake-build#3627 * SetEnvironmentVariable, fixes cake-build#3628 * UploadArtifact, fixes cake-build#3629 * Adds GitHub Actions * Runtime Info * Runner Name * Workflow ActionPath * fixes cake-build#3630 * Refactors GitHub Actions Paths, fixes cake-build#3631 * Initial work on BuildSystem integration tests * Adds GitHub Actions Commands integration tests
devlead
force-pushed
the
feature/gh-3627/gh-3628/gh-3629/gh-3630/gh-3631
branch
from
f6d30c2 to
e82aa32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.