Skip to content

GH3352: Add DirectoryPath + ConvertableDirectoryPath operator to ConvertableDirectoryPath#3353

Merged
devlead merged 1 commit into
cake-build:developfrom
augustoproiete-forks:add-dirpath-plus-convdirpath-operator
Oct 6, 2021
Merged

GH3352: Add DirectoryPath + ConvertableDirectoryPath operator to ConvertableDirectoryPath#3353
devlead merged 1 commit into
cake-build:developfrom
augustoproiete-forks:add-dirpath-plus-convdirpath-operator

Conversation

@augustoproiete

Copy link
Copy Markdown
Member

Closes #3352

@nils-a nils-a left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devlead devlead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some Directory tests to tests/integration/Cake.Common/IO/DirectoryAliases.cake to test this?

@devlead devlead changed the title (#3352) Add DirectoryPath + ConvertableDirectoryPath operator to ConvertableDirectoryPath GH3352: Add DirectoryPath + ConvertableDirectoryPath operator to ConvertableDirectoryPath Sep 7, 2021
@augustoproiete augustoproiete marked this pull request as draft October 5, 2021 17:39
@augustoproiete augustoproiete force-pushed the add-dirpath-plus-convdirpath-operator branch from 8b22dfc to 83d3f86 Compare October 5, 2021 22:18
@augustoproiete augustoproiete marked this pull request as ready for review October 5, 2021 22:27
@augustoproiete

augustoproiete commented Oct 5, 2021

Copy link
Copy Markdown
Member Author

Could we add some Directory tests to tests/integration/Cake.Common/IO/DirectoryAliases.cake to test this?

@devlead Integration tests added

@devlead devlead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 77c2a6b into cake-build:develop Oct 6, 2021
@devlead devlead deleted the add-dirpath-plus-convdirpath-operator branch October 6, 2021 09:28
@devlead

devlead commented Oct 6, 2021

Copy link
Copy Markdown
Member

@augustoproiete your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cake Frosting Parent DirectoryPath Fails To Combine with Slash

3 participants