Allow setting MSBuild target via MSBuildSettings using a string

[augustoproiete]

Currently when calling the MSBuild alias with an MSBuildSettings, we need to set the target using the WithTarget extension method.

MSBuild("./my-app.sln", new MSBuildSettings
{
    Configuration = "Release",
    ToolVersion = MSBuildToolVersion.VS2019,
}.WithTarget("Build")); // <<<###

It would be nice if we could use a property, with a string, which would make it more natural when using properties for everything else:

MSBuild("./my-app.sln", new MSBuildSettings
{
    Target = "Build",  // <<<###
    Configuration = "Release",
    ToolVersion = MSBuildToolVersion.VS2019,
});

This property should also understand semicolons as separator for multiple targets and call Targets.Add accordingly.

MSBuild("./my-app.sln", new MSBuildSettings
{
    Target = "Clean;Build",  // <<<###
    Configuration = "Release",
    ToolVersion = MSBuildToolVersion.VS2019,
});

What version of Cake are you using?

1.0.0-rc0001

Would you be willing to send a PR?

Yes!

[ManasviGoyal]

can you help me get started? @augustoproiete

[augustoproiete]

@ManasviGoyal In MSBuildSettingsExtensions you can see how the WithTarget method works today, and in MSBuildSettings you can see that Targets is a read-only property of type ISet<string>.

The way I probably would approach this would be:

• Introduce a new MSBuildTarget type that implements ISet<string> to represent a collection of targets and maintain compatibility with existing Cake scripts that might inspect the Targets property
• Modify the Targets property of MSBuildSettings to use this new MSBuildTarget type
• Modify the Targets property of MSBuildSettings to be read/write (i.e. add a setter)
• Implement an implicit string operator on MSBuildTarget that can parse strings delimited by ;
• Write unit tests for all the above
• Write integration tests to make sure the conversion operator works

Hope that helps!

[MariaSolOs]

@augustoproiete I'm preparing a PR to address this, but when running the tests in Cake.Common.Tests I get a bunch of Code should not contain trailing whitespace errors :(
The weird thing is that all of these refer to lines with documentation comments... I would appreciate some insight on how to fix this! (see my implementation here)

[augustoproiete]

@MariaSolOs It's exactly what the error message says. Your documentation comments have trailing spaces on them that should be removed.

e.g.

[MariaSolOs]

@augustoproiete thank you!
What about Constructor summary documentation should begin with standard text? What's the standard text? I've been trying to find a reference for it in the contribution and documentation docs...

[augustoproiete]

@MariaSolOs https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1642.md

[MariaSolOs]

Thank you @augustoproiete! I apologize for all the newbie questions.