ci: run on push to main and bump actions off Node 20#8
Merged
Conversation
Two small hardenings for the CI workflow: 1. Add "push: branches: [main]" trigger. Previously the workflow only ran on pull_request, so there was no CI signal on main itself — a PR could be merged with red checks and main would silently go red with no visible status. Running on push gives us a canonical green badge on main and surfaces regressions from direct pushes. 2. Bump deprecated Node 20 actions: - actions/checkout@v4 → @v6 - actions/setup-node@v4 → @v6 - pnpm/action-setup@v4 → @v5 All three moved to Node 24 in these majors (GitHub deprecates Node 20 action runtimes 2026-09-16). setup-node@v6 narrowed automatic caching to npm-only, but explicit "cache: pnpm" continues to work, which is what this workflow uses. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push: branches: [main]trigger — previously the workflow only ran onpull_request, so there was no CI signal onmainitself and red PRs could merge silently. Running on push gives us a canonical green/red status onmainand catches regressions from direct pushes.actions/checkout@v4→@v6actions/setup-node@v4→@v6pnpm/action-setup@v4→@v5GitHub is removing Node 20 action runtimes on 2026-09-16. All three bumped majors now run on Node 24.
Compatibility note
actions/setup-node@v6narrows automatic caching to npm-only. Our workflow usescache: pnpmexplicitly, which continues to work (confirmed in setup-node#1374).pnpm/action-setup@v5picks pnpm version from the rootpackage.jsonpackageManagerfield, same as before.Test plan
test,typecheck,lint,format,build) passes on this PR with the new action versionspushtrigger fires onmainand reports a status