fix(website): editorial follow-up to PR #134 interaction borderline findings#141
Merged
Conversation
…indings Acts on the four recommendations from PR #134's interaction borderline memo (decisions captured in repo-memory): - /bench Interactions section prose: honest reframe — "~1 ms over budget on all three scripts; 2-3.5× faster than every measured comparator." Includes the n=20 numbers (sort 17.10 ± 1.83; filter-metadata 17.51 ± 2.44; filter-text 16.79 ± 0.31). - ComparisonTable interaction rows: dropped the ≤ 16 budget reference (set to "—"); scroll rows keep their budget column. Replaced PR #131's n=3 numbers with the n=20 set; sort n=20 captured fresh in this PR (pretable-only matrix run, 17.10 ± 1.83 ms). - TanStack trail-marker label: dropped the "(filter-metadata ties pretable)" parenthetical. Tie was sampling noise at n=3; tanstack's distribution at higher repeats spans 8-42 ms. - Perf-fix investigation queued as a follow-up PR (wrapped-text filter pipeline is the shared root cause for all three interaction scripts landing over the single-frame budget). No test changes required: the TanStack regex (/headless.*slower interaction/i) still matches the shortened label. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…n verdict helper Mirrors the homepage TanStack trail-marker change. The n=20 verdict in PR #134 showed the n=3 'tie' was sampling noise; the page's verdict helper no longer renders the parenthetical even when the underlying summary still has the n=3 numbers that triggered the < 5% ratio test. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Vercel preview readyPreview: https://pretable-pmlzu70t9-cacheplane.vercel.app Updated automatically by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Acts on the four decisions you made on PR #134's recommendations. No auto-merge — editorial prose, needs your eyes.
≤ 16budget references (set to—); kept budget column for scroll rows(filter-metadata ties pretable)parentheticalWhat changed
apps/website/app/components/ComparisonTable.tsx— three interaction rows: budget≤ 16→—; numbers updated to n=20; TanStack trail-marker label shortened. Header docblock cites the new milestone source.apps/website/app/bench/page.tsx— Interactions section prose rewritten to acknowledge over-budget honestly while emphasizing the 2-3.5× comparator wedge.interactionVerdictForhelper drops the "ties pretable" parenthetical (matching the homepage trail-marker change).docs/research/repo-memory.md— 2026-05-13 entry capturing the four decisions and noting the perf-fix follow-up.New data captured in this PR
Pretable-only sort n=20 matrix run for consistency with the existing filter-text + filter-metadata n=20 data from PR #134:
All three reliably over the 16 ms single-frame budget. Reinforces the editorial direction and the case for the upcoming perf-fix investigation.
Test plan
pnpm -w typecheckpassespnpm -w testpasses (191 tests; TanStack regex/headless.*slower interaction/istill matches the shortened label)pnpm -w lint0 errorspnpm formatcleanWhat's NOT in this PR
/benchpage summary-file replacement. Page still reads PR feat(bench): B2 follow-up #5b — sort + filter comparator wiring #131's n=3 sort-filter summary; the n=20 numbers cited inline in the prose are accurate, and the verdict helper no longer renders the noise-tied parenthetical. A future PR could update the summary file or swap the page to read fromhypotheses.jsondirectly (per PR feat(bench-matrix): H6-H8 + H19-H21 evaluators embed comparator evidence #140's architecture).🤖 Generated with Claude Code