feat: add S7 pinned-inspection scenario with H9-H12 hypotheses#1
Merged
Conversation
New benchmark scenario with 3 pinned columns on variable-height inspection content, plus H9-H12 hypotheses mirroring S2's proof surface. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks: scenario-data definition, bench app wiring, bench-runner validation, hypothesis refactor (scenarioId param), H9-H12 tests, full verification. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
40 cols, 3 pinned left, 3 wrapped, variable-height, multilingual. Same row counts as S2. Exercises pinned-column layout overhead.
…tion scripts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
evaluateH1, evaluateH6-H8 now accept explicit scenarioId. Add H9-H12 wrappers for S7. Report grows from 5 to 9 hypotheses. Add S7 to DEFAULT_SCENARIOS.
Tests cover satisfied, failing, and insufficient states for composite scroll quality (H9) and interaction hypotheses (H10-H12) on the pinned-inspection scenario. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove dead `compareValues` function from derived-rows.ts and replace destructuring-based key removal with delete to avoid unused variable lint error. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Suppress react-hooks/refs and react-hooks/set-state-in-effect false positives for legitimate patterns (sync ref updates for callbacks, DOM measurement in useLayoutEffect). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
7 tasks
blove
added a commit
that referenced
this pull request
May 9, 2026
* chore(bench): high-repeat S2/scroll milestone for B2 follow-up perf diagnostic * docs(research): pretable vs MUI scroll perf diagnostic memo Phase C of B2 follow-up #1. Verdict: gap is noise. The high-repeat S2/hypothesis/scroll rerun shows no meaningful MUI advantage and recommends tightening H1-sensitive repeat protocol instead of scoping a perf-fix PR. Spec: docs/superpowers/specs/2026-05-09-b2-followup-perf-diagnostic-design.md Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * chore(bench): format perf diagnostic artifacts --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm bench:matrix -- --project=chromium --adapters=pretable --scenarios=S7 --scripts=scroll,sort,filter-metadata,filter-text --scale=dev --repeats=3pnpm bench:matrix -- --project=chromium --adapters=pretable,gridalpha,gridbeta,gridgamma --scenarios=S7 --scripts=scroll --scale=hypothesis --repeats=3*.hypotheses.json: H9-H12 present, 9 hypotheses total