Skip to content

Issue #118 Fix identifier quoting#120

Merged
bytefish merged 1 commit into
bytefish:masterfrom
krisse7:fix-identifier-quoting
Sep 2, 2022
Merged

Issue #118 Fix identifier quoting#120
bytefish merged 1 commit into
bytefish:masterfrom
krisse7:fix-identifier-quoting

Conversation

@krisse7
Copy link
Copy Markdown
Contributor

@krisse7 krisse7 commented Mar 12, 2022

Use PgJDBC Utils.escapeIdentifier() function to do the quoting. Fixes #118.

This changes the functionality of the quoteIdentifier() function so that it doesn't treat identifiers starting and ending with a double quote as already quoted.

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit b77199c and detected 0 issues on this pull request.

View more on Code Climate.

@bytefish
Copy link
Copy Markdown
Owner

Good job! I will need a little bit of time for the release, because I didn’t configure my current machine yet. So I will leave this open until I have set up my environment, so I won’t forget about it.

@krisse7
Copy link
Copy Markdown
Contributor Author

krisse7 commented Sep 2, 2022

Just a friendly reminder, it would be nice to get this merged and then get a new version released :)

@bytefish
Copy link
Copy Markdown
Owner

bytefish commented Sep 2, 2022

I will request a new PGP signing key for the packages first.

@bytefish bytefish merged commit 6a6f631 into bytefish:master Sep 2, 2022
@bytefish
Copy link
Copy Markdown
Owner

bytefish commented Sep 3, 2022

@krisse7 Released to Central Maven Repositories as 8.1.0. I think it will be available soon.

@bytefish
Copy link
Copy Markdown
Owner

bytefish commented Sep 3, 2022

@krisse7 Thanks for your patience and pinging me again, so I get my Java setup right again. 👍

@krisse7
Copy link
Copy Markdown
Contributor Author

krisse7 commented Sep 4, 2022

@bytefish Thanks a lot for the new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quoting algorithm is incorrect

2 participants