Omit cluster secret request bodies from REST debug logs

[lox]

Description

bk --debug dumps REST request bodies to stderr. Cluster secret create and value-update requests contain plaintext secret material, which should never be copied into terminal or CI logs.

Changes

• Omit request bodies entirely for cluster secret create and value-update endpoints while retaining request metadata and redacted headers.
• Preserve byte-for-byte request forwarding and continue showing bodies for unrelated endpoints.
• Recognize malformed secret paths, including extra slashes and URL delimiters, so invalid IDs cannot expose a body before the API rejects the request.
• Leave response debug dumps unchanged because the API does not return secret values.

Testing

• Tests have run locally (with go test ./...)
• Code is formatted (with go fmt ./...)

Disclosures / Credits

Amp implemented and tested this change under my direction.

[buildsworth-bk-app]

I found no code issues. This changes secret-redaction behavior in the shared debug transport, so it needs human review under the repository's approval policy.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 20206, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

About buildsworth

Model: gpt-5.6-sol with xhigh thinking.

How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.

Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. Unless repository policy already allows L2 approval, grant it by mentioning @buildsworth-bk (see approval ceiling and L2 approval grant):

• L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
• L2 — Standard risk (new UI, additive API fields, refactors). Approved only when repository policy or a verified grant allows it; otherwise comment-only.
• L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.

[buildsworth-bk-app]

One blocking redaction gap remains in the existing malformed-path thread.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 20426, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

Previous concerns have been addressed.

[buildsworth-bk-app]

The URL-delimiter redaction gap is fixed, and I found no new code issues. This still changes secret handling in the shared debug transport, so it needs human review.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 20751, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

[buildsworth-bk-app]

I found no code issues in the latest revision. This changes secret handling in the shared debug transport, so it still needs human review.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 20782, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

[buildsworth-bk-app]

I found no code issues in the latest revision. This changes handling of plaintext secrets in the shared REST debug transport, so it remains above the L1 approval ceiling and needs human review.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 20826, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.