Use canonical_id in rctx.download and use the latest github release version#62
Merged
perezd merged 1 commit intobufbuild:mainfrom May 29, 2024
Merged
Conversation
|
|
srikrsna-buf
changed the title
perezd
force-pushed
the
nsc/download-with-canonical-id
branch
from
eaa7833 to
8863878
Compare
perezd
approved these changes
May 29, 2024
|
Thank you! |
Merged
Merged
srikrsna-buf
added a commit
that referenced
this pull request
May 7, 2025
## What's Changed * Use canonical_id in rctx.download and use the latest github release version by @Strum355 in #62 * Fix running tests in Windows by @jchadwick-buf in #79 * Update bzlmod example to be able to use toolchain by @sfroment in #81 * Fix extensions.bzl to allow for multiple versions by @filippobrizzi in #88 * Add repository_url to reproducible attributes by @styurin in #94 * Sort targets in the buf_breaking rules by @dspencer12 in #100 * Add `buf_format` rule by @srikrsna-buf in #105 ## New Contributors * @Strum355 made their first contribution in #62 * @jchadwick-buf made their first contribution in #79 * @sfroment made their first contribution in #81 * @filippobrizzi made their first contribution in #88 * @dspencer12 made their first contribution in #101 * @styurin made their first contribution in #94 **Full Changelog**: v0.3.0...v0.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the docs:
default is ''. If set, restrict cache hits to those cases where the file was added to the cache with the same canonical idWith
http_archive, the default is the value of the url(s) provided, for the following reason:This helps catch the common mistake of updating the URLs without also updating the hash, resulting in builds that succeed locally but fail on machines without the file in the cache.The lack of this default for
rctx.downloadresulted in the exact issue described byhttp_archiveto us recently. As such, this PR updates uses ofrctx.downloadto mimic that behaviour to avoid this footgun.Also addresses a ~2yr old TODO around using https://api.github.com/repos/bufbuild/buf/releases/latest once v1 is hit