Conversation
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
|
Here's what it looks like going into the Bazel module registry: bazelbuild/bazel-central-registry#997 |
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
|
Thank you so much for this PR! Could you also add an example of using the |
|
Closes #33 |
|
@srikrsna-buf done |
|
Ping @srikrsna-buf |
|
Was caught up with something I'll take a closer look at this today. |
srikrsna-buf
left a comment
There was a problem hiding this comment.
Implementation looks good to me! Thank you!
Instead of a separate example can we add module files to the existing ones? Where they can be run in both modes? At a later stage we can just delete the contents of WORKSPACE file when that is no longer supported.
|
plis merge i cri everyday |
|
I am also in emotional distress @srikrsna-buf |
|
Hey @alexeagle! I am not sure if you can see this, but I reviewed it last week asking about the examples. If you have, then don't you think we should update all the examples? |
|
Hey @alexeagle , any update? |
|
I'll merge this and take up examples in a later PR, @DebkanchanSamadder you can use modules already based on thanks to @alexeagle for using a patch: bazelbuild/bazel-central-registry#997 |
|
@alexeagle I don't have permission to push to the fork, could you resolve the merge conflicts? Alternatively, I've resolved conflicts and pushed it to |
|
Can't seem to make it work with gazelle. Getting the following error here's the BUILD file load("@gazelle//:def.bzl", "DEFAULT_LANGUAGES", "gazelle", "gazelle_binary")
gazelle_binary(
name = "gazelle-buf",
languages = DEFAULT_LANGUAGES + [
# Loads the Buf extension
"@rules_buf//gazelle/buf:buf",
# NOTE: This needs to be loaded after the proto language
],
)
# gazelle:prefix github.com/ride-app/driver-service
# gazelle:build_file_name BUILD.bazel
# gazelle:exclude infra
# gazelle:proto disable_global
gazelle(
name = "gazelle",
gazelle = ":gazelle-buf",
) |
Bazel modules are moving away from setup in WORKSPACE files, towards a 'package manager' called bzlmod. Such modules are published on https://registry.bazel.build and are easier for developers to consume in their Bazel projects.
|
@srikrsna-buf I rebased it. Sorry I forgot about your request to merge the examples. I'll do that, but I'm not sure I can get to it right away, so yeah if you're okay to merge in this state, it would help folks who are trying to turn on bzlmod with Bazel 7 right now. |
|
I can merge this without the examples but was just looking at #42 (comment) to see if it works with gazelle. |
|
Actually lets merge this as is, I'll take up fixing it for gazelle in a followup pr as that is not being read from here. |
|
@srikrsna-buf thanks, can we work on publishing a release now? |
it comes from aspect-forks until bufbuild/rules_buf#42 is merged, hopefully for the next release
Bazel modules are moving away from setup in WORKSPACE files, towards a 'package manager' called bzlmod. Such modules are published on https://registry.bazel.build and are easier for developers to consume in their Bazel projects.