Support fully deterministic toolchain#36
Merged
srikrsna-buf merged 1 commit intobufbuild:mainfrom Oct 12, 2023
Merged
Conversation
Contributor
Author
|
@rubensf any chance this can get a review? |
srikrsna-buf
approved these changes
Jun 14, 2023
Contributor
Author
|
@srikrsna-buf thanks! Can we merge and cut a new release? |
|
ping @srikrsna-buf I'd like to contribute a Bzlmod setup to this repo, but I'm concerned if there's no maintenance going on that I'll waste my time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add a
sha256argument torules_buf_toolchainswhich allows for setting asha256value for the releasedsha256.txtfile. This is necessary in environments like Stripe where we do not allow any external dependencies that don't specify a SHA-256 in order to have fully deterministic external inputs. I've tested each combination of the inputs below.With neither
versionnorsha256:With just
version:With both
versionandsha256:If this change is acceptable, I'd like to request that it be released as v0.1.2.