Conversation
This PR changes the proto plugin to take into account the name of target being built to generate the args file. Before this patch, the rules that use the plugin will generate clashing args files (`path/to/rule/args`). This is fine if you run only one test at a time, but if you happen to have a `_lint` and a `_breaking` test in the same bazel package, an error pops up because both targets are trying to execute actions writing the same file.
|
Ricard Solé seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Thank you for the PR! I can reproduce the issue and also confirm that this fixes the issue. I'll merge once the cla is signed. Thanks again! |
👋 yeah sorry about the delay. i’m getting the CLA reviewed internally so that i can get it signed. hopefully it’ll get approved soon |
|
hey @srikrsna-buf Datadog’s legal team does not approve the “Intellectual Property Assignment” clause. Being that I would have been contributing as a Datadog Employee your agreement is requiring Datadog to “designate and appoint Buf Technologies and its duly authorized officers and agents as [Datadog’s] agent and attorney-in-fact” which is unacceptable under these circumstances. so i'm closing the PR, sorry for the trouble! |
3 participants
This PR changes the proto plugin to take into account the name of target
being built to generate the args file. Before this patch, the rules that
use the plugin will generate clashing args files (
path/to/rule/args).This is fine if you run only one test at a time, but if you happen to
have a
_lintand a_breakingtest in the same bazel package, anerror pops up because both targets are trying to execute actions writing
the same file.