ui: stats - default "This Year" filter hides all data for users with older sessions

[avelytchko]

Stats: default "This Year" filter hides all data for users with older sessions

Description

The /stats page defaults the date-range filter to This Year. For users whose only solves come from previous years (returning users on a fresh device, imported old backups, or anyone who has not solved yet this calendar year), the entire page renders empty - best/worst/average/charts all show no data - even though their data is intact.

The default also gets reset on every visit because the selection lives only in the URL query, so the user has to re-pick a wider range every time.

Steps to reproduce

1. Have a profile whose latest solve is from a previous calendar year (or import an old backup).
2. Open /stats on a fresh session.
3. The page shows no statistics; widening the filter to All Time reveals the actual data.

Expected

The default state of /stats should not hide existing data from a returning user. The user should not need to manually widen the range on every visit to see their own stats.

Recommended fixes

1. Default to "All Time"
2. Persist the last selected range
3. User-configurable default in Settings

[bryanlundberg]

That was a performance decision. For example, I had over 20k 3x3 solves, and opening the statistics page was always lagging because it had to execute all calculations every time, sometimes taking several seconds to load, and that’s on relatively good hardware. Other users could experience much worse slowdowns. It also becomes fairly irrelevant mathematically to include data from many previous years. Most of the time, you only want to see the single PB or ao5. Cost / benefit. But it’s true. Maybe it would be better to move it to persistence instead of keeping it in the URL state.