Repository navigation
Fix sidepanel chat context-limit recovery - #1110
Closed
Mike Hjazeen (Agentic Labs) (mjjjjaazing) wants to merge 1 commit into
Closed
Mike Hjazeen (Agentic Labs) (mjjjjaazing) wants to merge 1 commit into
Mike Hjazeen (Agentic Labs) (mjjjjaazing) wants to merge 1 commit into
Conversation
Contributor
|
PR author is not in the allowed authors list. |
Mike Hjazeen (Agentic Labs) (mjjjjaazing)
force-pushed
the
codex/context-limit-recovery
branch
from
June 5, 2026 13:07
178bdeb to
483b328
Compare
Contributor
|
Thanks so much for contributing to BrowserOS! 🙏 We're doing some housekeeping on our PR queue and closing out PRs that have been open for more than 7 days. This isn't a reflection on your work — we really appreciate the time and effort you put in. If this is still relevant, please feel free to reopen it or open a fresh PR and we'll take another look. Thanks again for being part of the project! 🚀 |
Dmitrii Vasilev (gHashTag)
added a commit
to gHashTag/BrowserOS
that referenced
this pull request
Sep 4, 2026
…browseros-ai#1111) (#308) Two bees ran in parallel with disjoint boundaries (browseros-ai#1110 owned rings/SR-02/QueenBranchCommitter.swift, browseros-ai#1109 owned rings/SR-02/ChatViewModel.swift and rings/SR-00/QueenReviewVerdictRequest.swift). browseros-ai#1110 made baseBranch() return String?, exactly as its criterion asked; the call site lived in the other bee's file. Both honoured the one-owner-per-path rule and the build broke: rings/SR-02/ChatViewModel.swift:4142: error: value of optional type 'String?' must be unwrapped to a value of type 'String' The boundary rule protects against a conflict of writes. It says nothing about a conflict of interfaces: a signature changed in one file breaks a different file, and only a build of the two states together can see it. The acceptance-side half landed with browseros-ai#1128 (runInterfaceDivergenceWatchdog compiles the combined state before any acceptance; transitionToAccepted takes the proof as a parameter, so no path to .accepted can skip it). What remained open was the issue's second criterion: drift-guard judges two worktrees it builds itself, not two states of this tree, so returning the former behaviour moved nothing. This file closes that gap with the decision itself, as a pure rule: - QueenInterfaceDivergence.verdict(between:) takes the interface facts of each lane (declarations whose shape changed, calls and the shapes they expect), overlays the lanes the way verifyCombinedBuild overlays branches, and reports every call that no longer matches, plus the two-changers-one- declaration case. Findings name both sides - who changed what, and who still calls the old shape - because a refusal that does not name its subject sends the reader hunting for the wrong problem. - The single-file suite rides in the same file behind QUEEN_INTERFACE_DIVERGENCE_SELFTEST and runs on the incident's own facts: the browseros-ai#1110/browseros-ai#1109 pair is refused, while a change whose call moved with it, a body-only change, and a new call written against the new shape all pass. The block holds declarations only: -emit-module typechecks even inactive #if branches (measured on the container), so a top-level entry would break the app build; the documented one-line driver keeps the file buildable and the suite runnable where no linker exists. - The revert proof is executable: formerIsolatedVerdict restates the pre-browseros-ai#1111 loop (each lane judged alone, nothing crosses a boundary) and the suite shows it accepts the incident pair that the rule refuses. Revert the rule to that judgement and the incident scenario fails its first check - the check breaks. Verified live against two mutants (the isolated revert and a blanket-refuse revert): both fail the suite loudly and non-zero. Nothing is imported, not even Foundation, so the rule compiles anywhere the Swift standard library does and the suite runs interpreted on the Linux container: 17 checks, 0 failures, parse/typecheck/emit-module green with the flag both off and on. Co-authored-by: queen-1111 bee <bee@trios.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
bun --env-file=.env.development test --preload=./tests/__helpers__/test-env.ts ./tests/api/services/chat-service.test.tsbun run typecheckbun run test:apigit diff --check