updating google-cloud-java nio to 0.62.0#5194
Merged
Conversation
Contributor
lbergelson
commented
Sep 17, 2018
- updating google-cloud-java 0.59.0 -> 0.62.0
- this includes retries on 502 errors see google-cloud-nio: retry on 502 errors, and increase max depth when doing channel reopens googleapis/google-cloud-java#3557
* updating google-cloud-java 0.59.0 -> 0.62.0 * this includes retries on 502 errors see googleapis/google-cloud-java#3557
droazen
approved these changes
Sep 17, 2018
Contributor
droazen
left a comment
There was a problem hiding this comment.
Merge when tests pass @lbergelson
Contributor
|
Note that the PR build has failed twice in a row with: |
Contributor
Author
|
weird... |
Contributor
|
@lbergelson This is failing deterministically with the above error on the OracleJDK only... |
Codecov Report
@@ Coverage Diff @@
## master #5194 +/- ##
===========================================
Coverage 86.806% 86.806%
Complexity 29679 29679
===========================================
Files 1815 1815
Lines 137203 137203
Branches 15144 15144
===========================================
Hits 119101 119101
Misses 12619 12619
Partials 5483 5483 |
Contributor
|
Aha, after clearing the travis cache for the PR build it passed! Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.