aes-gcm/x86-64: Tweak AVX2 VAES-VCLMUL.#2477
Closed
briansmith wants to merge 1 commit into
Closed
Conversation
briansmith
commented
Mar 12, 2025
| my $LO_XMM = "%xmm3"; | ||
| my $GHASH_ACC_XMM = "%xmm4"; # Different than upsream | ||
| my $BSWAP_MASK_XMM = "%xmm5"; # Different than upsream | ||
| my $GFPOLY_XMM = "%xmm6"; # Different than upsream |
Owner
Author
There was a problem hiding this comment.
Note: If we can avoid xmm6 then we can avoid a memory store in the prologue and a memory read in the epilogue on Windows.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2477 +/- ##
==========================================
- Coverage 96.61% 96.61% -0.01%
==========================================
Files 180 180
Lines 21814 21814
Branches 539 539
==========================================
- Hits 21076 21075 -1
Misses 623 623
- Partials 115 116 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
I suspect the version in PR #2478 will be better. |
Owner
Author
|
Closing this in favor of #2478 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.