NFC EC: DRY PRIVATE_SCALAR_OPS.oneRR_mod_n.limbs#1755
Merged
Conversation
Owner
Author
|
@vkrasnov Please review this. |
Codecov Report
@@ Coverage Diff @@
## main #1755 +/- ##
==========================================
- Coverage 95.98% 95.97% -0.02%
==========================================
Files 138 138
Lines 20609 20616 +7
Branches 221 221
==========================================
+ Hits 19782 19786 +4
- Misses 790 792 +2
- Partials 37 38 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Avoid repeating the value of `oneRR_mod_n` twice in each file.
briansmith
force-pushed
the
b/curve-gen-1
branch
from
869aeb5 to
7502367
Compare
vkrasnov
approved these changes
Oct 17, 2023
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p256.rs and p384.rs were inconsistently doing the same thing. Make them consistent. Also in the case of p256.rs, avoid repeating the value of the constant.