Repository navigation
fix(eval): resolve awaitable data before iteration - #917
Open
Gareth.Y (linjiaye929) wants to merge 1 commit into
Open
Gareth.Y (linjiaye929) wants to merge 1 commit into
Gareth.Y (linjiaye929) wants to merge 1 commit into
Conversation
Gareth.Y (linjiaye929)
marked this pull request as ready for review
October 13, 2026 04:19
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EvalDataexplicitly accepts an awaitable iterator or a factory returning one, but the evaluation runner iterates the coroutine without awaiting it. Passing an async data loader to eitherEval()orEvalAsync()therefore raisesTypeError: 'coroutine' object is not iterablebefore evaluating any rows.The implementation change is three lines; public signatures are unchanged.
Reproduction
Validation
Python 3.12.14, local editable SDK, test dependencies from the frozen
testdependency group:test_framework.py,test_parameters.py, andtest_score.py: 158 passed, 12 skipped. Eleven skips require optional Pydantic; one requires Python 3.14 lazy annotations.CI=1, cassette replay, the Braintrust pytest plugin disabled, and an external guard rejecting live socket connections.git diff --checkpassed.No live service/provider calls were used. The full core suite, full version matrix, type-checker sessions, and
make fixupwere not run.AI assistance
Prepared with AI assistance; the public-API reproduction, baseline failures, fix, and targeted tests were independently reviewed.
CI status
As checked on 2026-10-13 at 04:16:21 UTC for head
fe71940ef4137eea624a3a61f91d4fea2e9e2794, both upstream workflow runs reportaction_required:CI has not passed. The local validation above does not represent a successful upstream CI run.