Repository navigation
feat!: Add BRAINTRUST_CAPTURE_ATTACHMENTS env var option and captureAttachments logger option for all integrations - #2519
Merged
Conversation
Luca Forstner (lforst)
added a commit
that referenced
this pull request
Sep 24, 2026
Luca Forstner (lforst)
added a commit
that referenced
this pull request
Sep 28, 2026
Luca Forstner (lforst)
added a commit
that referenced
this pull request
Sep 28, 2026
Luca Forstner (lforst)
added a commit
that referenced
this pull request
Sep 28, 2026
Luca Forstner (lforst)
added a commit
that referenced
this pull request
Oct 1, 2026
Luca Forstner (lforst)
added a commit
that referenced
this pull request
Oct 1, 2026
…reAttachments` logger option for all integrations
Luca Forstner (lforst)
force-pushed
the
lforst/dum-e/melbourne-016f9385a8
branch
from
October 13, 2026 13:11
a4af22e to
c11a384
Compare
Member
Author
|
Codex (@codex) review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95d5c1a148
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Abhijeet Prasad (AbhiPrasad)
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref braintrustdata/braintrust-sdk-javascript#1841
Targets
v4(#2406).BRAINTRUST_CAPTURE_ATTACHMENTSenvironment variable; previously, integrations applied this setting inconsistently.initLogger({ captureAttachments: true | false })to override the environment setting. Loggers created withsetCurrent: falsekeep their own policy, independent of the global logger.Validation: build, type checks, lint, and 628 focused unit tests pass.
The affected replay e2e scenarios pass across three runs; production forwarding and generated Braintrust links were verified.
The full replay suite also hits existing v4 failures in the Git timestamp fixture and HarnessAgent fixture; both were reproduced on an untouched v4 checkout.