Repository navigation
ref!: Remove flushAsync option - #2409
Merged
Merged
Conversation
Luca Forstner (lforst)
force-pushed
the
lforst/dum-e/florence-0cc173acda
branch
from
August 28, 2026 15:58
15d91a5 to
11736b4
Compare
Luca Forstner (lforst)
changed the title
flushAsync option everywhereflushAsync option
Abhijeet Prasad (AbhiPrasad)
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref braintrustdata/braintrust-sdk-javascript#1841
flushAsyncgrinded my gears a bit a) as a user b) as a maintainer. Why?:flushAsyncoption to every tracing APIIn reality, what you can do instead, and which is very simple to understand, is simply do
await flush()orawait logger.flush()right after a span is ended. Not hard, very few if no drawbacks.